Re: [PATCH v6 0/4] pps-gpio: restore pin mux on unbind and shutdown

From: Rodolfo Giometti

Date: Thu Sep 24 2026 - 08:58:56 EST


On Wed, Sep 23, 2026 at 06:22:39PM +0000, Eliav Farber wrote:
Changes in v6:
- Patch 4: fold the pps_register_source() failure path into the same
dev_err_probe() + goto err_release_pins style as the other two paths
sharing that label, with a commit-message note that it is a logging
change, not a fix (Rodolfo Giometti)

That is exactly what I had in mind, thanks.

I applied the series here on v7.3-rc4: it applies cleanly, checkpatch
--strict is quiet on all four patches, and drivers/pps builds with W=1
and CONFIG_DEBUG_OBJECTS_TIMERS=y. I have acked the four patches
individually.

Andrew, could you please pick this up? LinuxPPS has no tree of its
own.

One leftover from the v5 review, not a blocker: the new shutdown()
runs on every board, including the ones that describe no "inactive"
state, where the free_irq() and the echo teardown buy nothing, and the
commit message of patch 4 still only speaks about the mux. If the
series needs a respin for some other reason, a line there would be
worth having -- otherwise it is fine as it stands.

Ciao,

Rodolfo