Re: [PATCH v6 2/4] pps: clients: gpio: only tear down the echo timer when it exists
From: Rodolfo Giometti
Date: Thu Sep 24 2026 - 08:59:23 EST
On Wed, Sep 23, 2026 at 06:22:41PM +0000, Eliav Farber wrote:
remove() calls timer_delete_sync() on data->echo_timer unconditionally,
but the timer is only initialised by timer_setup() in probe() when the
board describes an "echo" GPIO. On a board without echo-gpios the timer is
never set up, so remove() operates on a timer_list that was never
initialised.
Acked-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>