Re: [PATCH v12 03/25] x86/resctrl: Enumerate monitor features in rdt_get_l3_mon_config()

[Reinette Chatre]

Hi Tony,

On 9/16/26 4:12 PM, Tony Luck wrote:
> The original implementation of Intel Cache QoS Monitoring (CQM) planned
> to integrate with the "perf" and "cgroup" subsystems. With that plan it
> made sense for parameters from CPUID to be stored in fields of the
> cpuinfo_x86 structure. But that plan was abandoned and the resctrl file
> system user interface replaced it.
> 
> Change rdt_get_l3_mon_config() to make an explicit cpuid_count() call to

Above is obvious from the patch self. The changelogs of this series often
contain verbatim descriptions of code. Please replace these with descriptions
of _why_ the change is made.

Boris should not need to remind us again of his archeology test 
	https://lore.kernel.org/lkml/20250911165433.GBaML-yTUZHkywuJIe@fat_crate.local/

> enumerate L3 monitoring features in preparation for the removal of
> resctrl fields from cpuinfo_x86.

Considering above comment, could last paragraph be something like:
	Centralize all L3 monitoring enumeration within resctrl in
	preparation for removal of resctrl fields from struct cpuinfo_x86.

Using function names in the subject and changelog may expect folks to be familiar
with the code and in this case it is confusing since folks that are familiar
know that rdt_get_l3_mon_config() already enumerates monitoring features.

Could subject be something like:
	x86/resctrl: Centralize monitoring feature enumeration

> 
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---
The patch looks good.

Reinette