Re: [PATCH v12 05/25] x86/resctrl: Delete resctrl_cpu_detect()

[Reinette Chatre]

Hi Tony,

On 9/16/26 4:13 PM, Tony Luck wrote:
> cpuinfo_x86::x86_cache_{max_rmid,occ_scale,mbm_width_offset} are no
> longer used.
> 
> Delete resctrl_cpu_detect() and the fields from struct cpuinfo_x86.

Even though Boris already acked it I do think this can be improved to not
just describe the code in the patch, connecting it with the cleanup work,
and highlighting the benefit of removing resctrl from generic early CPU setup.

Something like:	
	x86/resctrl: Delete resctrl_cpu_detect()

	resctrl now enumerates its monitoring properties itself, leaving
	cpuinfo_x86::x86_cache_{max_rmid,occ_scale,mbm_width_offset} without any
	consumers. These resctrl specific fields are populated from the vendor
	CPU identification paths, unnecessarily placing resctrl details in
	generic x86 CPU	setup.

	Delete the unused fields together with the code that populates them,
	removing resctrl from early CPU identification.

> 
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> Acked-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>
> ---

Patch looks good.

Reinette