Re: [PATCH 3/6] dt-bindings: interrupt-controller: amazon,al-fic: add error/fatal groups

[Conor Dooley]

On Thu, Sep 24, 2026 at 06:23:08AM +0000, Eliav Farber wrote:
> FIC v2 and later expose two additional interrupt groups alongside the
> legacy group - an error group and a fatal group - each described by its
> own node and matched by a distinct compatible string. Turn the single
> compatible into an enum covering all three:

Without any explanation relating to hardware, I find this very hard to
understand. Nodes and compatible strings are devicetree concepts, that
portion of the commit message should explain hardware detail.

What this sounds like from your commit message is that you have a new
revision of this block, and instead of adding an al-fic-v2 compatible,
you're using two new compatibles to describe the new features and using
the old compatible to describe the common featureset. Without a dts, I
cannot say for sure.

pw-bot: changes-requested

> 
>   amazon,al-fic         - legacy group
>   amazon,al-fic-error   - error group
>   amazon,al-fic-fatal   - fatal group
> 
> Signed-off-by: Eliav Farber <farbere@xxxxxxxxxx>
> ---
>  .../bindings/interrupt-controller/amazon,al-fic.yaml         | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.yaml b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.yaml
> index 26bc05dee0bc..f43039901bd3 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.yaml
> @@ -11,7 +11,10 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: amazon,al-fic
> +    enum:
> +      - amazon,al-fic
> +      - amazon,al-fic-error
> +      - amazon,al-fic-fatal
>  
>    reg:
>      maxItems: 1
> -- 
> 2.47.3
>

Attachment: signature.asc
Description: PGP signature