Re: [PATCH 3/3] irqchip/gic-v3: Don't register a redistributor that was never counted

[Fuad Tabba]

On Thu, 24 Sep 2026 18:29:28 +0100, Marc Zyngier <maz@xxxxxxxxxx> wrote:

[...]

> Shouldn't this also update the broken_rdist bitmap?

Yes, it should. Without it gic_check_rdist() returns 0 and cpuhp
brings the CPU up. Sashiko raised the same [1], and I was in the
middle of replying with this:

        /* Not counted by gic_acpi_match_gicc(), so there is no slot for it */
        if (!gicc->gicr_base_address) {
                int cpu = get_cpu_for_acpi_id(gicc->uid);

                pr_warn(FW_BUG "GICC entry with ACPI UID %u has no
GICR base address, CPU kept offline\n",
                        gicc->uid);
                if (cpu >= 0)
                        cpumask_set_cpu(cpu, &broken_rdists);
                return 0;
        }

I'll fold it into a v2.

Cheers,
/fuad

[1] https://sashiko.dev/#/patchset/20260924161514.1112730-1-fuad.tabba%40linux.dev