Re: [PATCH 0/2] perf test: Improve shellcheck source directives

[Arnaldo Carvalho de Melo]

On Mon, Sep 21, 2026 at 01:46:25PM -0700, Namhyung Kim wrote:
> On Mon, Sep 21, 2026 at 04:47:27PM +0100, James Clark wrote:
> > Confusingly two things turned out to be relevant to this. One is that -a
> > doesn't make shellcheck follow "external" paths, which these are treated
> > as. You need -x for that. Secondly, the source= directives don't cause
> > it to follow the path either, they just suppress a warning message about
> > dynamic paths in versions of shellcheck before 0.7.2. This warning can
> > be silenced with "source=/dev/null" and doesn't require any particular
> > path to be provided if -x isn't used.

> > James Clark (2):
> >       perf test: Remove redundant shellcheck source paths
> >       perf build: Follow sourced files when running shellcheck
 
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks, applied to perf-tools-next, for v7.4.

- Arnaldo