Re: [PATCH v3 2/5] rust: pci: rework device enabling API
From: Danilo Krummrich
Date: Thu Sep 24 2026 - 14:17:30 EST
On Wed Aug 12, 2026 at 9:52 PM CEST, Maurice Hieronymus wrote:
> @@ -75,7 +77,7 @@ fn probe<'bound>(
> pin_init::pin_init_scope(move || {
> dev_dbg!(pdev, "Probe Nova Core GPU driver.\n");
>
> - pdev.enable_device_mem()?;
> + let enable = pdev.enable_device()?;
> pdev.set_master();
I think we could implement set_master() for pci::DeviceEnableGuard instead, so
it can't be called out of order.
Can you please do this in a separate patch?