Re: [PATCH net-next v21 1/3] dt-bindings: net: Document Motorcomm YT8824 PHY package

[Andrew Lunn]

> > +$ref: ethernet-phy-package.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - motorcomm,yt8824-package
> > +  phy-mode:
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    enum: [ internal, 10g-qxgmii ]
> 
> This should be after ref, but also have a vendor prefix.
> Additionally, the qcom ethernet-phy-package user also has a mode
> property. Net folks, should this be made common?

phy-mode is definitely wrong, it has a different meaning, and reusing
it is just going to cause confusion.

qcom,package-mode does have the same meaning as what is trying to be
expressed here. So yes, a common, vendor independent property would
make sense. It maybe should be in ethernet-phy-package.

	Andrew