Re: [RFC PATCH v2 02/10] x86/virt/tdx: Convert the version metadata reader

[Edgecombe, Rick P]

On Thu, 2026-09-24 at 13:50 +0800, Chao Gao wrote:
> > > +#define read_sys_metadata_table(_table, _data) \
> > > +	__read_sys_metadata_table(_table, ARRAY_SIZE(_table), _data)
> > 
> > Should this go in the previous patch?
> 
> I didn't put it there because the previous patch doesn't strictly need
> it; this patch is the first user.

Well the functions in the previous patch doesn't have any callers either...

> 
> Adding the macro in the previous patch while still tagging
> __read_sys_metadata_table() __maybe_unused looks a bit odd:
> the macro references the function, yet nothing uses either of them.

Ehh.

> 
> That said, I can move it if the oddness doesn't bother you.

I'd move it because it seems inconsistent to put it here.