Re: [PATCH 4/8] mtd: rawnand: qcom: make config_nand_cw_write() more generic

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] mtd: code and commit message mismatch for config_nand_cw_write prefix
--

commit 0e6310636afbfd85ec148281a9348c826d2b016a
Author: Gabor Juhos <j4g8y7@xxxxxxxxx>

mtd: rawnand: qcom: make config_nand_cw_write() more generic
    
This commit changes the declaration of config_nand_cw_write() to receive
a qcom_nand_controller pointer directly instead of a nand_chip pointer,
and renames the function.

> In order to make the function more generic, change the declaration
> to get a 'qcom_nandc_controller' pointer directly, and update the
> callers accordingly. While at it, also change the function name to
> use a 'qpic_nandc' prefix.
>
> No functional changes intended. This is in preparation of moving
> the function into the 'qpic_common' code to allow reusing it from
> the 'spi-qpic-snand' driver.

> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index 1f3c00823309f..99fbf54580836 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
[ ... ]
> @@ -378,10 +378,8 @@ static void qcom_nandc_config_page_write(struct qcom_nand_controller *nandc)
>   * Helper to prepare DMA descriptors for configuring registers
>   * before writing each codeword in NAND page.
>   */
> -static void config_nand_cw_write(struct nand_chip *chip)
> +static void qcom_nandc_config_cw_write(struct qcom_nand_controller *nandc)

[Severity: Medium]
The commit message states the function is being renamed to use a
'qpic_nandc' prefix, but here it is renamed to use a 'qcom_nandc_'
prefix instead.

Could the commit message be updated to match the actual code change, or
should the code be using the qpic prefix since the preparation is for
moving it into qpic_common?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-qcom_nandc-share-more-code-v1-0-f3012199b161@xxxxxxxxx?part=4