Re: [PATCH v2] x86/mm: Drop the page allocation from pud_free_pmd_page()

[Mikhail Gavrilov]

On 9/24/26 10:21, Dave Hansen wrote:
> OK, I've got a version of Mikhail's fix with a changelog and comments
> I've munged a bit:
>
>> https://git.kernel.org/pub/scm/linux/kernel/git/daveh/devel.git/log/?h=pmdfree
>
> Does that look OK to everyone?

Looks good to me, thanks.  The code is v2 with your comments and the
declarations reordered, so the testing done for v2 still applies.

Two small things, both optional:

 - "The new mmap_read_lock() is held over a GFP_KERNEL allocation":
   the lock held over the allocation is the same init_mm lock, but
   taken in vmap_try_huge_pud(), not the new one in CPA.  Maybe "The
   huge vmap code holds the same lock over a GFP_KERNEL allocation,
   which is a no-no now that reclaim can take it."

 - The kernel-doc lost its "Return:" line while the function still
   returns int, so kernel-doc -Wreturn will complain about it.