Re: [PATCH v3 7/7] mm: use VMA flag helpers in NUMA balancing

[David Hildenbrand (Arm)]

On 9/22/26 20:29, Gregory Price wrote:
> From: "Gregory Price (Meta)" <gourry@xxxxxxxxxx>
> 
> Use vma_test() instead of accessing vm_flags directly in the NUMA
> balancing code touched by the preceding fixes. Keep the existing flag
> predicates unchanged.
> 
> No functional change intended.
> 
> Suggested-by: Lorenzo Stoakes <ljs@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/aq1FDhy00epXXtgd@gremlin
> Assisted-by: LLM
> Signed-off-by: Gregory Price (Meta) <gourry@xxxxxxxxxx>
> ---
>  kernel/sched/fair.c | 3 ++-
>  mm/internal.h       | 2 +-
>  mm/migrate.c        | 2 +-
>  3 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 412c72084a63d..0d48d595740bf 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -4224,7 +4224,8 @@ static void task_numa_work(struct callback_head *work)
>  		 * under cache pressure can drive considerable bandwidth.
>  		 */
>  		placement_scan = !(vma->vm_file &&
> -			(vma->vm_flags & (VM_READ | VM_WRITE)) == VM_READ);
> +		    vma_test(vma, VMA_READ_BIT) &&
> +		    !vma_test(vma, VMA_WRITE_BIT));
>  

Indentation looks wrong.

Apart from that LGTM (did not check if there are other cases).

-- 
Cheers,

David