Re: [PATCH v7 3/3] arm64: dts: qcom: Add hamoa Samsung Galaxy Book4 Edge devicetrees

From: Maxim Storetvedt

Date: Thu Sep 24 2026 - 16:46:51 EST



On 9/24/26 15:08, Krzysztof Kozlowski wrote:
> On Sun, Sep 20, 2026 at 08:41:04PM +0200, Maxim Storetvedt wrote:
>> Adds devicetrees for the 14-inch and 16-inch hamoa SKUs of the Samsung Galaxy Book4 Edge.
>>
>> These use a common dtsi derived from nodes that were able to work on Linux
>> from the initial Galaxy Book4 Edge DTS by Marcus:
>>
>> Link: https://lore.kernel.org/all/p3mhtj2rp6y2ezuwpd2gu7dwx5cbckfu4s4pazcudi4j2wogtr@4yecb2bkeyms/
>>
>> combined with the patch series the Honor Magicbook Art 14, which shares device similarities:
>>
>> Link: https://lore.kernel.org/all/20260629154812.9066-1-mail@xxxxxxxxxxx/
>>
>> as well as a few more adjustments on top of that again to get additional features working.
>> Special thanks to Jesse Ahn for helping expand on what would eventually become this dtsi.
>>
>> Based-on-a-patch-by: Marcus Glocker <marcus@xxxxxxxxx>
>> Based-on-a-patch-by: Kirill A. Korinsky <kirill@xxxxxxxxx>
>
> There are no such tags. Don't invent own.
>
> Either they provided SoB for the code you used, or not. If they did,
> then you could take them. Otherwise not and read obligations on your
> side expressed in DCO.
>
> Also look at Co-developed tag, if that's applicable.
>
> Best regards,
> Krzysztof
>

Not formal tags by any means; both of these patches have been very
useful though, and should somehow be highlighted. Bon, to be revisited.

In the meantime, there seem to be some sashiko warnings that need to be
addressed before this series can continue in any case.

Cheers,
-Max