Re: [PATCH v2 11/19] platform/x86/intel/tpmi: Include the headers tpmi_common.c relies on

[Andy Shevchenko]

On Thu, Sep 24, 2026 at 11:23:33AM -0700, Kuppuswamy Sathyanarayanan wrote:
> tpmi_common.c uses a number of interfaces whose headers it never includes
> directly and only gets by chance through other headers:
> 
>   BIT_ULL(), GENMASK_ULL()	bits.h
>   __packed			compiler_attributes.h
>   EXPORT_SYMBOL_NS_GPL()	export.h
>   DEFINE_IDA()			idr.h
>   IORESOURCE_MEM		ioport.h
>   DEFINE_MUTEX(), mutex_lock()	mutex.h
>   seq_printf(), seq_hex_dump()	seq_file.h
>   kmalloc(), kzalloc_flex()	slab.h
>   USEC_PER_MSEC, USEC_PER_SEC	time64.h
>   uXX				types.h
> 
> Include them, so that the file does not break when an unrelated header
> stops pulling them in.
> 
> Drop io.h while at it, as iopoll.h already includes it, and sort the
> block alphabetically: debugfs.h and cleanup.h were the wrong way round.
> 
> No functional change intended.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko