Re: [PATCH v2 15/19] platform/x86/intel/tpmi: Build the TPMI control words in one expression

From: Andy Shevchenko

Date: Thu Sep 24 2026 - 17:16:55 EST


On Thu, Sep 24, 2026 at 11:23:37AM -0700, Kuppuswamy Sathyanarayanan wrote:
> Both mailbox words in tpmi_read_feature_status() are assembled as an
> assignment followed by an or-assign of a second field, even though
> neither value is used in between. Build each of them in a single
> expression, so that a word and the fields it is made of read as one
> thing.
>
> The two comments on the command word described one value between them, so
> fold them together as well.
>
> No functional change intended.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

--
With Best Regards,
Andy Shevchenko