Re: [PATCH net v3 4/8] vsock: drop the re-assignment logic
From: Michal Luczaj
Date: Thu Sep 24 2026 - 17:29:15 EST
On 9/24/26 15:15, netdev-bot+sashiko@xxxxxxxxxx wrote:
> [Severity: Medium]
> Is the invariant behind this assertion always true? The commit message
> says "On a failed connect(), transport is de-assigned", but
> vsock_unconnected_reset() can return early without de-assigning:
Addressed in comments to patch #3.
> [Severity: Low]
> Could the new precondition be documented?
Yes.
> [Severity: Low]
> With this block gone, two comments elsewhere in the file still explain a
> load-bearing check in terms of reassignment. Should they be updated?
Yes.