Re: [PATCH RESEND net-next v17 05/10] net: phy: Represent PHY-less SFP modules with phy_port

[Aleksei Sviridkin]

On Thu, 10 Sep 2026 19:00:57 +0200, Maxime Chevallier wrote:
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> [...]
> @@ -724,6 +727,7 @@ struct phy_device {
>  	unsigned irq_rerun:1;
>  
>  	unsigned default_timestamp:1;
> +	unsigned has_sfp_mod_phy:1;

has_sfp_mod_phy lands in the same word as interrupts, irq_suspended and
irq_rerun. It is written from the SFP state machine under rtnl, while
irq_rerun is written from phy_interrupt(), so one update can undo the
other. A plain bool next to sfp_bus_attached would avoid sharing the
word.

Aleksei