Re: [PATCH v7 1/2] ASoC: Intel: Add Cherry Trail RT5677 machine driver

[Maurizio Casciano]

Hi Mark,

You're right; I missed this review. Sorry about that.

> snd_soc_substream_to_rtd()

Changed to snd_soc_substream_to_rtd() in v8.

> Shouldn't this be using an ACPI formatted name?

Changed to "i2c-104C227E:00", matching the ACPI-enumerated component name
and the existing Cherry Trail TS3A227E machine driver.

> We ask for more names below...

The later requests are for "speaker-enable2" and "headphone-enable".
Those are RT5677 GPIO2 and GPIO4, supplied as software-node properties by
the Yoga Book platform/x86 v3 series:

https://lore.kernel.org/r/20260829225729.395270-1-mauriziocasciano7@xxxxxxxxx

Only "speaker-enable" comes from the codec device's ACPI _CRS and needs
the ACPI GPIO mapping in this driver. The v7 cover letter failed to state
the platform/x86 runtime dependency. v8 now documents it in both the
commit message and cover letter.

I sent v8 as a new thread here:

https://lore.kernel.org/r/20260925003030.1077471-1-mauriziocasciano7@xxxxxxxxx

It is rebased on ASoC for-next at 74612d0b448f and the two affected
objects build with W=1 on the remote build host.

With Best Regards,
Maurizio Casciano