Re: [PATCH v2] iio: cdc: ad7150: fix OF matching and publish module aliases
From: Jonathan Cameron
Date: Thu Sep 24 2026 - 21:50:33 EST
On Tue, 22 Sep 2026 13:26:51 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> On Sun, Sep 20, 2026 at 11:33:03AM +0800, Pengpeng Hou wrote:
> > The OF match entries use positional initializers, which initialize the
> > name field rather than compatible. Consequently the advertised AD7150,
> > AD7151 and AD7156 compatible strings do not describe OF compatible
> > matches. The table is also not exported for module alias generation.
> >
> > Use designated compatible initializers and publish the OF table. Keep
> > the existing I2C ID table and its device-variant selection unchanged.
> >
> > The issue was found by our static-analysis tool.
> >
> > Fixes: 89f2d5b080bc ("staging:iio:cdc:ad7150: Add of_match_table")
> > Assisted-by: gpt 5
>
> Assisted-by: LLM
>
> > Signed-off-by: Pengpeng Hou <hppiscas@xxxxxxx>
>
> Same to other patches with similar tag.
>
> ...
>
> TBH, except the commit message I can't see how LLM could be helpful to the
> code. It's quite a simple change...
>
Applied with the Assisted by tweaked.
Thanks,
Jonathan