Re: [PATCH v9 0/5] iio: magnetometer: ak8975: driver cleanup
From: Jonathan Cameron
Date: Thu Sep 24 2026 - 22:29:59 EST
On Sun, 20 Sep 2026 20:05:22 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:
> This is a 4-month old series that I had in my working tree and
> completely forgot about. It's a continuation of the ak8975 driver
> cleanup that Andy and I worked on, all that was missing was to
> implement Jonathan's powered_on bool idea. The rest of the patches
> have Reviewed-by tags.
>
> Very sorry for the long delay :(
>
> Original cover letter contents:
>
> This series is a continuation of the previous ak8975 driver cleanup
> effort, as most of the patches were picked.
>
> Changes include:
> - using BIT() and GENMASK() macros
> - moving to devm_* resource management
> - adding a scan index enum
> - moving from using wait loops to iopoll functions
> - various code style changes
>
> Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
Applied with the tweaks called out in patch 3 (and a commit message
to mention that was rolled in).
Thanks,
Jonathan
> ---
> Changes in v9:
> - Add powered_on bool per Jonathan's review
> - Move forgotten dev_err() call to use a local dev variable
> - Link to v8: https://lore.kernel.org/all/20260518-magnetometer-fixes-post-pickup-v8-0-088d610108a0@xxxxxxxxx/
>
> ---
> Andy Shevchenko (4):
> iio: magnetometer: ak8975: switch to using managed resources
> iio: magnetometer: ak8975: unify messages with help of dev_err_probe()
> iio: magnetometer: ak8975: use temporary variable for struct device
> iio: magnetometer: ak8975: make use of the macros from bits.h
>
> Joshua Crofts (1):
> iio: magnetometer: ak8975: add scan mask index enum
>
> drivers/iio/magnetometer/ak8975.c | 213 +++++++++++++++++++-------------------
> 1 file changed, 107 insertions(+), 106 deletions(-)
> ---
> base-commit: 40288c9206c17eb66a603262e06a58d300d0f279
> change-id: 20260919-ak8975-cleanup-206e303af804
>
> Best regards,