Re: [PATCH v2 4/4] iomap: don't lose a failed direct I/O bio's error when zeroing the tail

From: Christoph Hellwig

Date: Fri Sep 25 2026 - 00:54:54 EST


> -static int iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio,
> - loff_t pos, unsigned len)
> +static void iomap_dio_zero(const struct iomap_iter *iter,
> + struct iomap_dio *dio, loff_t pos,
> + unsigned int len)

Please drop this reformatting. While not all of the kernel agrees,
the two-tab indent style is technically much superior and we want to
stick to it for iomap.

Otherwise thi looks great, thanks!