Re: [PATCH v2 7/7] nvme: fcloop: Add set_marginal_rport to sysfs

[Hannes Reinecke]

On 9/23/26 6:16 PM, Jesse Taube wrote:
> On Wed, Sep 23, 2026 at 11:34 AM Hannes Reinecke <hare@xxxxxxx> wrote:
> > On 9/23/26 4:56 PM, Jesse Taube wrote:
> > > On Mon, Sep 21, 2026 at 10:03 AM Hannes Reinecke <hare@xxxxxxx> wrote:
> > > >
[ .. ]
> > > > > @@ -1671,6 +1719,7 @@ static DEVICE_ATTR(del_remote_port, 0200, NULL, fcloop_delete_remote_port);
> > > > >     static DEVICE_ATTR(add_target_port, 0200, NULL, fcloop_create_target_port);
> > > > >     static DEVICE_ATTR(del_target_port, 0200, NULL, fcloop_delete_target_port);
> > > > >     static DEVICE_ATTR(set_cmd_drop, 0200, NULL, fcloop_set_cmd_drop);
> > > > > +static DEVICE_ATTR(set_marginal_rport, 0200, NULL, fcloop_set_marginal_rport);
> > > > >
> > > > >     static struct attribute *fcloop_dev_attrs[] = {
> > > > >         &dev_attr_add_local_port.attr,
> > > > > @@ -1680,6 +1729,7 @@ static struct attribute *fcloop_dev_attrs[] = {
> > > > >         &dev_attr_add_target_port.attr,
> > > > >         &dev_attr_del_target_port.attr,
> > > > >         &dev_attr_set_cmd_drop.attr,
> > > > > +     &dev_attr_set_marginal_rport.attr,
> > > > >         NULL
> > > > >     };
> > > > Please don't make it a fabrics option.
> > >
> > > What do you mean by fabrics option? How should I fix this?
> > Your patch does two things; one is to modify the parser in
> > fcloop_parse_options, and the other is to implement a new
> > sysfs rport attribute 'set_marginal_rport()'.
> > My suggestion is to drop the first part;
>
> You want to drop the parser?
Yes. 'set_marginal_rport()' sets a boolean value.
You don't really need a parser for that.

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxx                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich