Re: [PATCH v5 7/9] iomap: reject atomic writes in iomap_file_buffered_write()

[Hannes Reinecke]

On 9/24/26 1:56 AM, Tal Zussman wrote:
> Buffered atomic writes are not currently supported. The page cache
> writes folios back independently, so it cannot guarantee that a range is
> written atomically. iomap_file_buffered_write() does not check for
> IOCB_ATOMIC, so a direct write that falls back to it would complete an
> atomic write without atomicity. While no such case currently exists,
> fail IOCB_ATOMIC writes with -EOPNOTSUPP, so that a future fallback
> cannot complete an atomic write non-atomically.
>
> Suggested-by: John Garry <john.garry@xxxxxxxxx>
> Signed-off-by: Tal Zussman <tz2294@xxxxxxxxxxxx>
> ---
>   fs/iomap/buffered-io.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 0a5ebfda90f1..e6654cfe1cbf 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -1304,6 +1304,10 @@ iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *i,
>   	};
>   	ssize_t ret;
>   
> +	/* Buffered atomic writes are not supported */
> +	if (iocb->ki_flags & IOCB_ATOMIC)
> +		return -EOPNOTSUPP;
> +
>   	if (iocb->ki_flags & IOCB_NOWAIT)
>   		iter.flags |= IOMAP_NOWAIT;
>   	if (iocb->ki_flags & IOCB_DONTCACHE)
Reviewed-by: Hannes Reinecke <hare@xxxxxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxx                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich