Re: [PATCH v2] nvmet-tcp: fix stale comment on NVMET_TCP_MAXH2CDATA
From: Christoph Hellwig
Date: Fri Sep 25 2026 - 02:57:22 EST
On Wed, Sep 23, 2026 at 09:39:59AM +0200, Maurizio Lombardi wrote:
> On Wed Sep 23, 2026 at 6:20 AM CEST, Ing. Alfonso Kuen Arroyo wrote:
> > The constant is 0x400000, 4 MiB, but the comment next to it said 16M.
> > Use SZ_4M instead of a value and a comment that can drift out of sync
> > with each other, as suggested by Christoph Hellwig.
> >
> > Noticed by Maurizio Lombardi while reviewing "nvmet-tcp: report a
> > bounded MDTS instead of "no limit"".
> >
> > v2: use SZ_4M instead of the raw hex value + comment (Christoph
> > Hellwig). The file did not pull in linux/sizes.h yet and had no
> > other SZ_ user, so the include is added.
>
> version differences should be put after the '---' separator, they are
> not part of the commit message
>
> >
> > Signed-off-by: Alfonso Kuen
>
> The mail is missing, this should be:
> Signed-off-by: Alfonso Kuen <gerencia@xxxxxxxxxxxxxx>
Agreed on both. Otherwise this looks great, thanks.