Re: [PATCH v2 0/2] iio: adc: add support for the MAX34417 Four-Channel High Dynamic Range Power Accumulator

[Neil Armstrong]

Hi Jonathan,

On 9/25/26 05:13, Jonathan Cameron wrote:
> On Thu, 24 Sep 2026 15:14:14 +0200
> Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote:
>
> > The MAX34417 is a specialized current and voltage monitor used to determine
> > power consumption of portable systems. The driver support getting the channel
> > voltage and accumulated average power over an I2C/SMBUS serial interface.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
>
> Hi Neil,
>
> As pointed out too fast for a v2.  You aren't new upstream so
> that shouldn't come as a surprise!

Yeah sorry, but with the initial feedback v1 was far form beeing
acceptable, will adjust timings for next versions.

> Secondly for devices that are all about monitoring power supplies
> etc we always ask for a clear statement of why IIO rather than
> hwmon + to CC at least the maintainer and often the hwmon list.

Sure, thanks for the suggestion.

> There are various valid reasons for that choice, but it is good
> if they are clearly stated for discussion.

I don't honestly have an strong opinion on that, for me IIO offers
much more options to retrieve data from the sensor and adding the
complex feature offered. The IIO triggers for example would
perfectly match with the bulk readout we coulnd't implement with
the hwmon API.

Thanks,
Neil

> Thanks,
>
> Jonathan
>
> > ---
> > Changes in v2:
> > - switch to shunt-resistor-micro-ohms no more required
> > - removed gpio.h from example
> > - Fixed max34417->MAX34417 in Kconfig and comments
> > - Added missing includes and remove unneeded
> > - Fixed typos in comments
> > - Switched to fsleep()
> > - Better aligned max34417_read_power declararation
> > - Handled 0 acc_count
> > - Switched to GENMASK_ULL() for 32bits systems
> > - Added missing empty lines
> > - Moved the input correction into a helper
> > - Set default input correction for all channels
> > - Switched to dev_err_probe() to return from probe
> > - Switched to device_for_each_child_node_scoped()
> > - Handled invalid shunt-resistor-micro-ohms value
> > - Link to v1: https://patch.msgid.link/20260923-topic-sm8x50-iio-max34417-adc-v1-0-41d4ba1bfc41@xxxxxxxxxx
> >
> > ---
> > Neil Armstrong (2):
> >        dt-bindings: iio: add: document the MAX34417 Four-Channel High Dynamic Range Power Accumulator
> >        iio: adc: add driver for the MAX34417 Four-Channel High Dynamic Range Power Accumulator
> >
> >   .../bindings/iio/adc/maxim,max34417.yaml           | 100 ++++++
> >   drivers/iio/adc/Kconfig                            |  11 +
> >   drivers/iio/adc/Makefile                           |   1 +
> >   drivers/iio/adc/max34417.c                         | 374 +++++++++++++++++++++
> >   4 files changed, 486 insertions(+)
> > ---
> > base-commit: fd73f4a6659897191fa0d40695fe370925dd3780
> > change-id: 20260923-topic-sm8x50-iio-max34417-adc-209e880533fb
> >
> > Best regards,
> > --
> > Neil Armstrong <neil.armstrong@xxxxxxxxxx>