Re: [PATCH] nfc: llcp: Fix socket reference leak in nfc_llcp_recv_ui()

From: Simon Horman

Date: Fri Sep 25 2026 - 05:05:18 EST


On Sun, Sep 20, 2026 at 07:48:19AM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
>
> Critical: 0 (1) · High: 1 · Medium: 0 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] Incomplete fix: the identical nfc_llcp_sock_get() reference leak
> remains at the sibling call site in nfc_llcp_recv_connect()…

This concern matches my analysis.
I would suggest an updated patch that fixes both functions.

>
> Pre-existing issues:
> - [Critical] Post-handoff SKB access / use-after-free race in
> nfc_llcp_recv_ui() (net/nfc/llcp_core.c:902-907): the extra SKB…

...