Re: [PATCH net v2 1/2] net: ethtool: don't match a hwtstamp provider on a device without a PHC

[Nicolai Buchwitz]

On 24.9.2026 14:20, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 · Medium: 1 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let 
> patchwork
> know by including "pw-bot: cr" as a separate line at the end of your 
> reply
> (one such reply per series is enough).
>
> - [High] The fix is incomplete.
> - [Medium] The patch deals with the 0xFFFFFFFF/-1 aliasing through an
>   open-coded check at one comparison site instead of rejecting the 
> value…
>
> --

> [...]

> [Severity: High]
> Can the same -1 == -1 match still happen in the PHY half of the lookup?

Unfortunately yes. In v3 I will reject the value in the netlink policy.

> [...]
>
> [Severity: Medium]
> Would it be better to reject 0xFFFFFFFF at the netlink boundary instead 
> of
> adding an open-coded check at one comparison site?

Will do in v3 (NLA_POLICY_FULL_RANGE).

> [...]

pw-bot: cr