Re: [PATCH net v2 2/2] net: ethtool: let tsconfig reach a PHY-only timestamp provider

[Nicolai Buchwitz]

On 24.9.2026 14:20, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let 
> patchwork
> know by including "pw-bot: cr" as a separate line at the end of your 
> reply
> (one such reply per series is enough).
>
> - [Medium] ethnl_set_tsconfig() can now install an 
> HWTSTAMP_SOURCE_NETDEV
>   provider on a device that has no hwtstamp NDOs, and that provider 
> can…
> - [Low] The new TSCONFIG_SET gate in ethnl_set_tsconfig()
>   (tsconfig.c:303-305) looks only at whether dev->phydev is the 
> default…
>
> --

> [...]

> [Severity: Medium]
>
> The commit message says "this makes a netdev provider reachable without
> ndo_hwtstamp_get". Should a netdev provider be reachable at all on a 
> device
> without the NDOs?

No. v3 will pick the netdev source only when ndo_hwtstamp_set is 
available.

> [...]

> [Severity: Low]
>
> This check runs before dev->hwprov or the requested provider is looked 
> at,
> and it only considers dev->phydev. Could it reject requests that an 
> already
> installed PHYLIB provider can serve?

Right, it ignores an installed provider. v3 will also pass when 
dev->hwprov is set.

> [...]

pw-bot: cr