Re: [PATCH RFC 06/11] ACPI: GTDT: Convert SBSA watchdog to IRQ properties

[Andy Shevchenko]

On Fri, Sep 25, 2026 at 09:48:05AM +0200, Lorenzo Pieralisi wrote:
> SBSA watchdog IRQs might be wired to interrupt controllers that are
> probed after the SBSA watchdog is probed and therefore the IRQ mappings
> cannot be carried out at platform device creation but deferred to
> SBSA watchdog probing through the platform_get_irq*() set of APIs.
> 
> To do that, stash the GSI number, trigger, polarity into standard
> properties attached to a software node that is attached to the
> platform device ACPI static fwnode, allowing the SBSA driver to
> retrieve those properties and map the IRQ when the SBSA driver
> is probed.
> 
> Signed-off-by: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>
> Cc: Hanjun Guo <guohanjun@xxxxxxxxxx>
> Cc: Sudeep Holla <sudeep.holla@xxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> ---

Same about the Cc list...

...

>  	struct resource res[] = {
>  		DEFINE_RES_MEM(wd->control_frame_address, SZ_4K),
>  		DEFINE_RES_MEM(wd->refresh_frame_address, SZ_4K),
> -		{},

Side note, even in the old code the last entry should be rather DEFINE_RES().
Because some APIs, such as resource_size() will not work on an 'empty'
resource.

>  	};

-- 
With Best Regards,
Andy Shevchenko