Re: [PATCH net 4/6] net: bcmasp: fix OF node reference leak for phy_dn

[Nicolai Buchwitz]

On 23.9.2026 00:16, Florian Fainelli wrote:
> In bcmasp_interface_create(), intf->phy_dn is obtained via
> of_parse_phandle() or assigned ndev_dn. of_parse_phandle() returns a
> node reference with its refcount incremented, but of_node_put() was
> never called on intf->phy_dn in bcmasp_interface_destroy() or the
> error unwind path in bcmasp_interface_create().
>
> Acquire a reference on ndev_dn for the fixed-link case as well so that
> intf->phy_dn consistently holds a reference, and release it with
> of_node_put() on teardown and error.
>
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet 
> controller")
> Assisted-by: LLM
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> ---
>  drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c 
> b/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> index 2ad8a7eac888..7a63a592f158 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> @@ -1298,7 +1298,7 @@ struct bcmasp_intf 
> *bcmasp_interface_create(struct bcmasp_priv *priv,
>  				 ndev_dn->name);
>  			goto err_free_netdev;
>  		}
> -		intf->phy_dn = ndev_dn;
> +		intf->phy_dn = of_node_get(ndev_dn);
>  	}
>
>  	/* Map resource */
> @@ -1338,6 +1338,7 @@ struct bcmasp_intf 
> *bcmasp_interface_create(struct bcmasp_priv *priv,
>  err_deregister_fixed_link:
>  	if (of_phy_is_fixed_link(ndev_dn))
>  		of_phy_deregister_fixed_link(ndev_dn);
> +	of_node_put(intf->phy_dn);
>  err_free_netdev:
>  	free_netdev(ndev);
>  err:
> @@ -1350,6 +1351,7 @@ void bcmasp_interface_destroy(struct bcmasp_intf 
> *intf)
>  		unregister_netdev(intf->ndev);
>  	if (of_phy_is_fixed_link(intf->ndev_dn))
>  		of_phy_deregister_fixed_link(intf->ndev_dn);
> +	of_node_put(intf->phy_dn);
>  	free_netdev(intf->ndev);
>  }

Reviewed-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>

Thanks,
Nicolai