Re: [PATCH v3] perf symbols: Apply the symfs flat layout to the composed filename

[Arnaldo Carvalho de Melo]

On Thu, Sep 24, 2026 at 03:30:48PM -0700, Namhyung Kim wrote:
> On Tue, Sep 22, 2026 at 09:19:52PM +0800, Zhan Xusheng wrote:
> > BUILDID_DEBUGINFO needs one more step: the build id cache splits the first
> > two characters of the build id off into a directory name, so the basename
> > of the hierarchy path is only part of the build id.  Name the flat file
> > after the whole build id.
> > 
> > dso__disassemble_filename() passes a path from perf's own build id cache
> > rather than one on the profiled system, and every entry there is named
> > "elf" or "debug".  Use path__join() so the layout does not apply.
> > 
> > With --symfs /s,flat the lookups are now /s/libc.so.6, /s/libc.so.6.debug,
> > /s/sleep and /s/<build id>.debug.  hierarchy is unchanged.
> > 
> > Signed-off-by: Zhan Xusheng <zhanxusheng@xxxxxxxxxx>
> 
> Reviewed-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks, applied to perf-tools-next, for v7.4.

- Arnaldo