Re: [PATCH net-next v4 3/8] net: dsa: motorcomm: Identify port type at runtime
From: David Yang
Date: Fri Sep 25 2026 - 09:06:42 EST
On Fri, Sep 25, 2026 at 10:19 AM <netdev-bot+sashiko@xxxxxxxxxx> wrote:
>
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] The commit message says "no behavior changes intended", but
> the patch changes which registers are programmed on SerDes link-up and…
> - [Low] yt921x_port_up() chooses the XMII register block using only
> pp->serdes and never checks info->xmii_mask.
Slop - you cannot get xmii on serdes ports.