Re: [PATCH net-next 1/3] selftests: drv-net: Introduce a selftest for ethtool flow control

[Maxime Chevallier]

On 9/24/26 15:54, Andrew Lunn wrote:
> On Wed, Sep 23, 2026 at 08:10:51PM -0700, Jakub Kicinski wrote:
>> On Wed, 23 Sep 2026 07:41:13 +0200 Maxime Chevallier wrote:
>>> On 9/23/26 04:42, Jakub Kicinski wrote:
>>>> On Sun, 20 Sep 2026 18:47:27 +0200 Maxime Chevallier (Netdev
>>>> Foundation) wrote:  
>>>>> Future ethtool selftests are expected to use the same, these helpers
>>>>> are put in the net selftest lib.  
>>>>
>>>> Please resist the urge to create libraries.
>>>>
>>>> If you're doing this I suspect you didn't even read the README and 
>>>> you expect people to search around for libraries?  
>>>
>>> I did read the README and fought the urge, that was something Andrew
>>> was asking for in the previous round :( I'm ok with either TBH.
>>
>> I guess it was Andrew that didn't read the docs then :)
> 
> Yes.
> 
> I apply software engineering principles to tests as i would to any
> other code. It has to be maintained, bug fixed etc. For my $DAY_JOB, i
> spend as much time maintaining test code as feature code. So i don't
> really want lots of copy/paste version of the same code.
> 
> So, for flow control, lets follow the README. When EEE is implemented,
> we can see how bad the copy/paste is, and then consider a library.

Some side question, as the whole thing goes into the same file, do you
prefer that the series stays split into 3 patches, or do you prefer
the whole thing in one single patch ?

The diffstat would be :

tools/testing/selftests/drivers/net/hw/Makefile |   1 +
tools/testing/selftests/drivers/net/hw/pause.py | 998 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Maxime