Re: [PATCH v4 7/8] slimbus: qcom-ngd-ctrl: Remove data channels on stream disable
From: David Heidelberg
Date: Fri Sep 25 2026 - 10:35:06 EST
On 25/09/2026 10:09, Srinivas Kandagatla wrote:
On 9/24/26 2:24 PM, David Heidelberg via B4 Relay wrote:...and I see you just merged resent v3 today :)
From: David Heidelberg <david@xxxxxxx>
qcom_slim_ngd_xfer_msg() silently returns success for every core
reconfiguration message, so the generic channel removal done by
slim_stream_disable() never reaches the ADSP SLIMbus master. The
master therefore keeps the channels of a closed stream. When the next
stream defines the same channel numbers again, the WCD9340 capture
completes without any error but records only zeros; removing the
channels explicitly when the stream is disabled makes it work again.
Implement the disable_stream controller op with the sequence the
downstream NGD driver sends for channel removal, CHAN_CTRL(REMOVE)
listing the stream's channels followed by RECONFIG_NOW. Like
downstream, treat -EREMOTEIO from the removal as success: it means the
controller is being restarted and the channels are gone anyway.
Based on work done by Casey Tunturi.
Assisted-by: Claude:claude-fable-5-1
Signed-off-by: David Heidelberg <david@xxxxxxx>
---
there is an identical patch on the list,
https://lore.kernel.org/linux-arm-msm/247e4ce7-1ba2-43b8-8a11-ec70f99a4fc1@xxxxxxxxxx/T/#m3b50aa43a6493f8d3b607b1607b37bf14b199f69
I'll drop this patch from the series then.
Thank you
David