Re: [PATCH v2 06/17] clk: spacemit: k3: parent eDP/DP pixel clock to the PHY PLL

[Jerome Brunet]

On dim. 09 août 2026 at 21:14, Cody Kang <codykang.hk@xxxxxxxxx> wrote:

> The APMU eDP/DP pixel-clock muxes were parented to a placeholder, because
> their real parents (the DP PHY PLLs) did not exist as clocks yet. They do
> now, so point each mux at its PLL and let the pixel clock reach the
> controller through the clock framework.
>
> Signed-off-by: Cody Kang <codykang.hk@xxxxxxxxx>
>
> ---
> v2:
> - no change
> ---
>  drivers/clk/spacemit/ccu-k3.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/spacemit/ccu-k3.c b/drivers/clk/spacemit/ccu-k3.c
> index cb0c4277f72a8..afbbbd797826d 100644
> --- a/drivers/clk/spacemit/ccu-k3.c
> +++ b/drivers/clk/spacemit/ccu-k3.c
> @@ -937,13 +937,13 @@ CCU_MUX_DIV_GATE_FC_DEFINE(ufs_aclk, ufs_aclk_parents, APMU_UFS_CLK_RES_CTRL, 5,
>  
>  static const struct clk_parent_data edp0_pclk_parents[] = {
>  	CCU_PARENT_HW(lcd_pxclk),
> -	CCU_PARENT_NAME(external_clk),
> +	CCU_PARENT_NAME(edp0_pll_pxclk),

hidden behind this macro is a .fw_name. Basically these are your DT
input names. You can't change them at will like that because your
bindings are supposed to be stable.

You should not use placeholder name, ever. No need to make the
name too specific either, from the beginning it should have been
something like "pixel_pll" or whatever your doc refer it with.

"external_clk" is not declared in your bindings AFAICT, so at least it
should be fine to remove it.

There need to be a dt-binding patch documenting the new name you need
and then you can start using it in the driver.

In the future, please try to document all the inputs of your controller
in the bindings. Even if you do not use them yet, they exist.

>  };
>  CCU_MUX_GATE_DEFINE(edp0_pxclk, edp0_pclk_parents, APMU_LCD_EDP_CTRL, 2, 1, BIT(1), 0);
>  
>  static const struct clk_parent_data edp1_pclk_parents[] = {
>  	CCU_PARENT_HW(dsi4ln2_lcd_pxclk),
> -	CCU_PARENT_NAME(external_clk),
> +	CCU_PARENT_NAME(edp1_pll_pxclk),
>  };
>  CCU_MUX_GATE_DEFINE(edp1_pxclk, edp1_pclk_parents, APMU_LCD_EDP_CTRL, 18, 1, BIT(17), 0);
>  
>
> -- 
> 2.43.0
>

-- 
Jerome