Re: [PATCH 2/3] arm64: dts: qcom: glymur: Add videocc sleep clock
From: Shawn Guo
Date: Fri Sep 25 2026 - 11:35:29 EST
On Fri, Sep 25, 2026 at 12:48:07PM +0300, Abel Vesa wrote:
> On 26-09-25 00:11:51, Shawn Guo wrote:
> > The videocc node supplies only the two XO inputs. videocc-glymur.c
> > expects a third input, DT_SLEEP_CLK, and uses it as the parent of
> > video_cc_sleep_clk_src, so that RCG cannot resolve its parent and ends
> > up as an orphan clock: any clk_set_rate() on it fails, and it shows up
> > parentless in /sys/kernel/debug/clk/clk_summary.
> >
> > Nothing is broken at runtime today because VIDEO_CC_SLEEP_CLK (0x8138)
> > is listed in video_cc_glymur_critical_cbcrs and is therefore force
> > enabled through regmap, bypassing the clock framework; the sleep source
> > simply keeps whatever rate the bootloader left. The orphan still blocks
> > any future rate management of the video sleep path.
> >
> > Pass the board sleep clock as the third input. The sibling evacc node
> > on the same SoC already does this.
>
> Same question as on the 3rd patch.
This patch doesn't drop GCC_VIDEO_AHB_CLK or any videocc input clock
like 3rd patch but only adding the board sleep clock as the third input.
So it shouldn't break videocc either. It would nice if you can give it a
test on your X2 laptop though :)
Shawn