Re: [PATCH v1] perf test: stat metrics cgroup strip possible slash from cgroup name
From: Namhyung Kim
Date: Fri Sep 25 2026 - 11:43:11 EST
On Wed, Sep 16, 2026 at 11:13:12PM -0700, Ian Rogers wrote:
> The grep to match cgroup name in metric output assumes no leading / on
> the cgroup name, however, cgroups in /proc/self/cgroup may have a
> leading /. Strip the / if it exists to avoid failures to match the
> cgroup name in the perf stat output.
>
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>
Thanks,
Namhyung
> ---
> tools/perf/tests/shell/stat_metrics_cgrp.sh | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tools/perf/tests/shell/stat_metrics_cgrp.sh b/tools/perf/tests/shell/stat_metrics_cgrp.sh
> index d4226ee0ae98..0728f48f21fa 100755
> --- a/tools/perf/tests/shell/stat_metrics_cgrp.sh
> +++ b/tools/perf/tests/shell/stat_metrics_cgrp.sh
> @@ -86,6 +86,13 @@ check_metric_reported()
>
> for cgrp in "${cgrps[@]}"; do
> # Find metric lines for this cgroup
> + case "$cgrp" in
> + /) # The root cgroup, leave unchanged.
> + ;;
> + /*) # Strip any starting slashes.
> + cgrp="${cgrp#/}"
> + ;;
> + esac
> # We use exact cgroup match with surrounding commas
> local cgrp_lines
> cgrp_lines=$(echo "${output}" | grep -F ",${cgrp}," | grep "insn_per_cycle" || true)
> --
> 2.55.0.1082.g2b9226bbc0-goog
>