Re: [PATCH 5/6] ASoC: codecs: aw88166: remove async start

[Aaron Kling]

On Fri, Sep 25, 2026 at 9:35 AM Cezary Rojewski
<cezary.rojewski@xxxxxxxxx> wrote:
>
> On 9/25/2026 9:47 AM, Aaron Kling via B4 Relay wrote:
> > From: Aaron Kling <webgeek1234@xxxxxxxxx>
> >
> > Codec drivers are not supposed to do anything like this. The result was
> > that the first second or so of playback was essentially inaudible, and
> > very short alert sounds could be missed entirely. Let's not do this.
> Do anything like what?
> Let's not do what?
>
> With all due respect, the commit message found here is so vague I'm
> surprised people even review this.  Your change is not a one-liner
> cleanup.  I'd expect at least a short description provided, on what is
> happening _currently_ and _why_ removal improves the functional
> behaviour of the codec device.

As mentioned in the cover letter, this series is a direct copy of
changes to the aw88261 driver, which went through three revisions and
was accepted in this form. The matching patch is here [0]. What makes
this worse than the already merged patch?

Aaron

https://lore.kernel.org/linux-sound/20260529200550.529719-6-val@xxxxxxxxxxxx/