Re: [PATCH v2 4/5] thermal: Use %pe to print error pointers symbolically

[Rafael J. Wysocki (Intel)]

On Sat, Sep 12, 2026 at 9:13 PM Sumeet Pawnikar <sumeet4linux@xxxxxxxxx> wrote:
>
> Replace PTR_ERR() and %ld with %pe and pass the original pointer directly
> to pr_err() and dev_err(). The %pe format specifier prints a symbolic error
> name (e.g. -ENOMEM) when CONFIG_SYMBOLIC_ERRNAME is enabled, otherwise it
> falls back gracefully and prints the raw integer value. This makes messages
> more readable without any functional change.
>
> Signed-off-by: Sumeet Pawnikar <sumeet4linux@xxxxxxxxx>
> ---
>  drivers/thermal/cpufreq_cooling.c        | 4 ++--
>  drivers/thermal/devfreq_cooling.c        | 4 ++--
>  drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c
> index 768859a7aed0..856d619370db 100644
> --- a/drivers/thermal/cpufreq_cooling.c
> +++ b/drivers/thermal/cpufreq_cooling.c
> @@ -661,8 +661,8 @@ of_cpufreq_cooling_register(struct cpufreq_policy *policy)
>
>                 cdev = __cpufreq_cooling_register(np, policy, em);
>                 if (IS_ERR(cdev)) {
> -                       pr_err("cpufreq_cooling: cpu%d failed to register as cooling device: %ld\n",
> -                              policy->cpu, PTR_ERR(cdev));
> +                       pr_err("cpufreq_cooling: cpu%d failed to register as cooling device: %pe\n",
> +                              policy->cpu, cdev);
>                         cdev = NULL;
>                 }
>         }
> diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c
> index 0330a8112832..9ada52cbf7dd 100644
> --- a/drivers/thermal/devfreq_cooling.c
> +++ b/drivers/thermal/devfreq_cooling.c
> @@ -156,8 +156,8 @@ static unsigned long get_voltage(struct devfreq *df, unsigned long freq)
>                 opp = dev_pm_opp_find_freq_exact(dev, freq, false);
>
>         if (IS_ERR(opp)) {
> -               dev_err_ratelimited(dev, "Failed to find OPP for frequency %lu: %ld\n",
> -                                   freq, PTR_ERR(opp));
> +               dev_err_ratelimited(dev, "Failed to find OPP for frequency %lu: %pe\n",
> +                                   freq, opp);
>                 return 0;
>         }
>
> diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> index af72db6299cd..4554a6fa55d1 100644
> --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> @@ -680,8 +680,8 @@ static int adc_tm5_register_tzd(struct adc_tm5_chip *adc_tm)
>                                 continue;
>                         }
>
> -                       dev_err(adc_tm->dev, "Error registering TZ zone for channel %d: %ld\n",
> -                               adc_tm->channels[i].channel, PTR_ERR(tzd));
> +                       dev_err(adc_tm->dev, "Error registering TZ zone for channel %d: %pe\n",
> +                               adc_tm->channels[i].channel, tzd);
>                         return PTR_ERR(tzd);
>                 }
>                 adc_tm->channels[i].tzd = tzd;
> --

Applied as 7.4 material, thanks!