Re: [PATCH RFC 10/10] arm64: dts: qcom: sm6125-xiaomi-ginkgo: enable display, backlight and touchscreen

[Barnabás Czémán]

On 2026-09-21 13:26, Konrad Dybcio wrote:
> On 9/11/26 10:51 AM, YİĞİTCAN KAVAKLI via B4 Relay wrote:
> > From: YİĞİTCAN KAVAKLI <kavakliyigitcan@xxxxxxxxx>
> >
> > Enable the display subsystem (MDSS/MDP/DSI0), Kinetic KTD3136 
> > backlight,
> > and Novatek NT36672A SPI touchscreen on the Xiaomi Redmi Note 8 
> > (ginkgo).
> >
> > Hardware nodes added:
> > - Fixed LCDB regulators (lcdb_lab and lcdb_ibb at +/- 5.5V)
> > - MDSS and DSI0 with Tianma 1080x2340 FHD+ video panel
> > - I2C1 backlight node at 0x36 with PMI632 GPIO 6 hardware enable
> > - SPI2 touchscreen node at CS0 with GPIO 88 interrupt and panel 
> > follower
> >   reference
> > - Touchscreen active pinctrl definition on GPIO 88
> >
> > Signed-off-by: YİĞİTCAN KAVAKLI <kavakliyigitcan@xxxxxxxxx>
> > ---
> >  .../boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi | 100 
> > +++++++++++++++++++++
> >  1 file changed, 100 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi 
> > b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi
> > index 
> > 59042a5937535c4acda064fa0f865f4f5a52d01b..f4b9e2092a814e56cdc23218025cb4166dec110a 
> > 100644
> > --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi
> > @@ -26,11 +26,30 @@ / {
> >  	chassis-type = "handset";
> >
> >  	qcom,msm-id = <QCOM_ID_SM6125 0x10000>;
> > +	qcom,board-id = <34 0>, <34 1>, <34 2>, <34 3>, <34 4>, <0 0>;
>
> This should be a separate patch with the reasoning for the change

board-id is not neccesary for this device to be able to boot so it can 
be removed. I have already done that before so it should not be readded.
> >  	aliases {
> >  		serial0 = &uart4;
> >  	};
> >
> > +	lcdb_lab: regulator-lcdb-lab {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "lcdb_lab";
> > +		regulator-min-microvolt = <5500000>;
> > +		regulator-max-microvolt = <5500000>;
> > +		regulator-boot-on;
> > +		regulator-always-on;
> > +	};
> > +
> > +	lcdb_ibb: regulator-lcdb-ibb {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "lcdb_ibb";
> > +		regulator-min-microvolt = <5500000>;
> > +		regulator-max-microvolt = <5500000>;
> > +		regulator-boot-on;
> > +		regulator-always-on;
> > +	};
>
> LAB/IBB and LCDB are separate hardware blocks, only LCDB is
> present on PMI632. It provides a pair of pos/neg bias
> voltages. Looks like downstream has a driver for controlling
> this block.
>
> Konrad