Re: [PATCH 1/2] thermal: intel: powerclamp: Simplify duration_get()

[Rafael J. Wysocki (Intel)]

On Wed, Sep 16, 2026 at 12:16 AM Thorsten Blum <blum@xxxxxxxxxx> wrote:
>
> Use guard(mutex) and return the result of sysfs_emit() directly to
> simplify the code. Also use %u to format the unsigned duration.
>
> Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>
> ---
>  drivers/thermal/intel/intel_powerclamp.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/thermal/intel/intel_powerclamp.c b/drivers/thermal/intel/intel_powerclamp.c
> index bd7fd98dc310..8ceb1270646c 100644
> --- a/drivers/thermal/intel/intel_powerclamp.c
> +++ b/drivers/thermal/intel/intel_powerclamp.c
> @@ -103,13 +103,9 @@ static int duration_set(const char *arg, const struct kernel_param *kp)
>
>  static int duration_get(char *buf, const struct kernel_param *kp)
>  {
> -       int ret;
> +       guard(mutex)(&powerclamp_lock);
>
> -       mutex_lock(&powerclamp_lock);
> -       ret = sysfs_emit(buf, "%d\n", duration / 1000);
> -       mutex_unlock(&powerclamp_lock);
> -
> -       return ret;
> +       return sysfs_emit(buf, "%u\n", duration / 1000);
>  }
>
>  static const struct kernel_param_ops duration_ops = {

Applied as 7.4 material along with the [2/2], thanks!