Re: Compilation error in [PATCH v7 0/3] Add support for the Sony IMX681 camera sensor

[Sergey Lebedev]

German,

Thanks for isolating it to 2/3. The patch is fine on the base it was
written for; v7.3-rc4 is missing one media commit it depends on.

The series is against media/next, as the cover letter says
(aedd77ea8168). There, 7eef49c1646 ("media: v4l2-subdev: Add struct
v4l2_subdev_client_info pointer to pad ops") gave .set_fmt,
.get_selection and .set_selection a new argument, and imx681 is written
to it. -rc4 does not have that commit, so the driver's two pad ops no
longer match the fields they are assigned to, and the kernel builds
with -Werror=incompatible-pointer-types.

Checked both ways today with the same config and compiler. On
aedd77ea8168 the series applies and imx681.o builds with W=1 and no
warnings. On v7.3-rc4, git apply refuses the Makefile context; applied
with patch(1), the build fails with exactly two errors, at the .set_fmt
and .get_selection initialisers. linux-next already carries the change.

For testing on -rc4 in the meantime I have sent you a two-line change
off-list.

Sergey