Re: [PATCH net-next 1/3] selftests: drv-net: Introduce a selftest for ethtool flow control

[Jakub Kicinski]

On Thu, 24 Sep 2026 15:54:36 +0200 Andrew Lunn wrote:
> I apply software engineering principles to tests as i would to any
> other code. It has to be maintained, bug fixed etc. For my $DAY_JOB, i
> spend as much time maintaining test code as feature code. So i don't
> really want lots of copy/paste version of the same code.

FTR I disagree. Driver ksft are partially born out of my frustration
with people treating "tests as normal software engineering" which
somehow always ends up overly complex. Every team or group of people
has their own, and it gets rewritten whenever the employee who wrote
the initial version quits.

Simple, linear scripts which one can read without digging thru modules
are the best possible tests. Even if they are 4x longer.