Re: [PATCH net v2 3/5] net: bcmgenet: do not skip WoL power up on GENET V1

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 1 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] The commit message of "net: bcmgenet: do not skip WoL power up
  on GENET V1" (387c3a954a3a) ends with the malformed trailer `Siged-…

--

net: bcmgenet: do not skip WoL power up on GENET V1

This moves the bcmgenet_has_ext(priv) test out of the top of
bcmgenet_power_up() and into the GENET_POWER_PASSIVE and
GENET_POWER_CABLE_SENSE cases, where the EXT registers are actually
touched. That lets the GENET_POWER_WOL_MAGIC case reach
bcmgenet_wol_power_up_cfg() on GENET V1, which has no EXT block.

The only comment below is about the commit message trailers, so the diff
hunks are omitted.

> Fixes: c3ae64ae0c08 ("net: bcmgenet: handle GENET_POWER_WOL_MAGIC")
> Assisted-by: LLM
> Reviewed-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>
> Siged-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
  ^^^^^^^^^^^^

[Severity: Medium]
This isn't a code bug, but should this read Signed-off-by: instead of
Siged-off-by:?

As spelled, the trailer is not matched by checkpatch.pl or the patchwork
netdev checks, so the patch appears to have no author sign-off.

The other four patches in the same series use the correct spelling, so
this looks like an isolated typo in this patch only. Since a trailer can
only be corrected by amending this commit, would a resend be needed here?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260921220021.281418-1-florian.fainelli%40broadcom.com