Re: [PATCH] tty: add break_wait kernel-doc
From: Randy Dunlap
Date: Fri Sep 25 2026 - 20:33:05 EST
On 9/25/26 2:42 AM, Johan Hovold wrote:
> Add the missing kernel-doc description for the new break_wait field in
> struct tty_struct.
>
> Fixes: c7e9bff9b4b3 ("tty: abort break signalling on hangup")
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Link: https://lore.kernel.org/20d75a7a-2e7a-484f-a267-c21db82dd922@xxxxxxxxxxxxx
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
FWIW. Too late, I suppose:
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Thanks.
> ---
> include/linux/tty.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/tty.h b/include/linux/tty.h
> index ad4e4a835f90..833bb7b97ceb 100644
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -168,6 +168,7 @@ struct tty_operations;
> * @write_wait: concurrent writers are waiting in this queue until they are
> * allowed to write
> * @read_wait: readers wait for data in this queue
> + * @break_wait: wait queue for timed breaks
> * @hangup_work: normally a work to perform a hangup (do_tty_hangup()); while
> * freeing the tty, (re)used to release_one_tty()
> * @disc_data: pointer to @ldisc's private data (e.g. to &struct n_tty_data)
--
~Randy