Re: [PATCH net-next 1/6] net: add netif_rx_mode_schedule_fresh()

[Jakub Kicinski]

On Thu, 24 Sep 2026 23:01:48 +0000 netdev-bot+sashiko@xxxxxxxxxx wrote:
> The kernel-doc says the helper is for callers which need "the complete
> receive configuration to be replayed".  Does the helper on its own produce
> that replay for an ndo_set_rx_mode_async driver?
> 
> The queued run ends up in netif_rx_mode_run(), which snapshots the address
> lists and then reconciles them.  __hw_addr_list_snapshot() copies sync_cnt
> and refcount, __hw_addr_sync_dev() skips entries whose sync_cnt is already
> nonzero, and the reconcile step then computes a zero delta, so addresses
> that were already marked synced are not pushed to the driver again.

I was about to say this, the kdoc promises a full replay which is also
what I suspect you want. but the callback delivers incremental updates
by default so if the device was synced calling this does nothing.

If you do want full replay please fix, and also call it _replay()
we already use that verb eg in udp_tunnel_nic_replay()

If you just want a retry the kdoc and name should be updated..
-- 
pw-bot: cr