Re: [PATCH v15 07/11] phy: rockchip: usbdp: Hold mutex in DP PHY configure

[Manivannan Sadhasivam]

On Tue, Sep 15, 2026 at 05:06:10PM +0200, Sebastian Reichel wrote:
> rk_udphy_dp_phy_configure() accesses some variables from the struct
> rk_udphy, which are updated independently from the USB-C framework.
> 
> The USB-C mux/orientation switch functions already hold a mutex to
> ensure mutual exclusive access to the struct rk_udphy states, so
> simply hold the same one in the DP PHY configuration function.
> 
> Reproducing problems due to this on real hardware would be really hard,
> but could be possible when quickly re-connecting the USB-C connector.
> 
> Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver")
> Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-phy/20260612164627.23D391F000E9@xxxxxxxxxxxxxxx/
> Tested-by: Igor Paunovic <royalnet026@xxxxxxxxx> # Orange Pi 5 Plus
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>

- Mani

-- 
மணிவண்ணன் சதாசிவம்