Re: [PATCH] arm64: dts: qcom: x1e80100-dell-xps13-9345: add the front camera

[Abel Vesa]

On 26-09-25 14:10:24, Liviu Nicoara wrote:
> Describe the OV02C10 front camera on CCI1 bus 1 at 0x36, fed by MCLK4
> at 19.2 MHz into CSIPHY4 over two D-PHY lanes at 400 MHz, the only
> link frequency the ov02c10 driver offers.
> 
> The wiring comes from the Windows driver store. CAMF_RES_QRD.bin
> switches a single rail, GPIO 91, before releasing reset on GPIO 237;
> GPIOs 235 and 236 are muxed to aon_cci there, the CCI1 bus 1 pins, not
> rail enables. No camera resource file votes a PMIC rail for the
> sensor, so avdd and dvdd are left out and fall to dummy regulators.
> The CSI PHY file votes LDO1_C at 1.2 V and LDO2_C at 0.88 V for the
> PHYs, which is vdda-1p2 and vdda-0p9 here, as on the Inspiron 14 Plus.
> MCLK drive strength is 2 mA, as CAMP_RES_QRD.bin programs GPIO 100,
> and tested streaming.
> 
> The module sits upside down in the lid: with both sensor flips on, the
> picture is upright and unmirrored, so rotation is 180.
> 
> The white camera indicator on GPIO 110 becomes the sensor's privacy LED,
> so the V4L2 core lights it while the sensor streams and takes it away
> from sysfs; the comment waiting for a "camera on" trigger goes.
> 
> Depends on the x1e80100 camera DT series (v7), and on the CAMSS PHY API
> patches (v20 5/6 and 6/6), which read the CAMSS endpoint's data-lanes
> as 1-based.

This shouldn't be part of the commit message. Drop it.

> 
> Assisted-by: LLM
> Signed-off-by: Liviu Nicoara <lnicoara@xxxxxxxxxxxx>

At some point, there was a patch from Laurentiu Tudor, but I cannot find
that patch on the mailing list, so I guess you sent it first.