Re: [RFC PATCH net-next v3 4/5] net: dsa: qca8k: flag QCA8337 internal CPU PHYs for SmartSpeed

[Andrew Lunn]

> The OpenWrt DTS for this board sets qcom,dac-preset-short-cable on the
> IPQ5018 GE PHY. The qca,ar803x.yaml binding describes it as adjusting
> amplitude, bias current and error correction for a PHY connected to
> another PHY over a short distance. There is no equivalent setting on the
> QCA8337 side.

I'm leaning towards the hardware design is broken, not enough
attenuation etc, causing the PHY to wrongly detect a broken pair.

The IPQ5018 PHY driver does have cable test support, have you tried it
out?

Downshift itself, in the normal setting with a cable, probably does
work, otherwise we would of had reports of issues.

Although the PHY on the CPU port is not associated to a Linux
interface, it is still probed, and has a phydev. So you should be able
to represent it in DT, and add a DT property to disable
downshift. This would sometimes run into problems in that DT should
describe hardware, not the configuration of the hardware. But in this
case, if in the commit message and comments you say downshift needs to
be disabled because of a bad hardware design, i expect it will be
accepted.

	Andrew